Please update inst/rkward/plugins/non_parametric_tests/kruskal_wallis.js #1
Conversation
The "split is not a function" error occurs when we call the split() method on a value that is not of type string. To solve the error, convert the value to a string using the toString() method before calling the split method or make sure to only call the split method on strings. https://bobbyhadz.com/blog/javascript-typeerror-string-split-is-not-a-function#:~:text=The%20%22split%20is%20not%20a,the%20split%20method%20on%20strings.
Update common_functions.js
The QtScript has informed of an error: Script Error in file:///usr/share/rkward/phpfiles/common.js, line 31: TypeError: Cannot read property 'noquote' of undefined Backtrace: quote@file:///usr/share/rkward/phpfiles/common.js:31 makeHeaderCode@file:///usr/share/rkward/phpfiles/common.js:91 @file:///usr/share/rkward/phpfiles/common.js:113 printout@file:///home/username/R/x86_64-pc-linux-gnu-library/4.2/rkTeaching/rkward/plugins/non_parametric_tests/kruskal_wallis.js:68 do_printout@file:///usr/share/rkward/phpfiles/common.js:178 %entry@:1
Update kruskal_wallis.js
Update description
|
As for the patch in kruskal_wallis.js, yes of course I want to merge that fix. Thanks! Your merge request contains a number of additional changes, however, and I am not sure, what to make of these. I suppose some of these (e.g. the language changes in data_weighting) got into the MR, by accident. Others may or may not be intended to be merged. Could you review the changes, and elaborate a bit? |
First of all, just to say thanks for all the time and hard work you and all the team put on this!!! Yeah, got those additional changes mixed up. Those are some workarounds to some glitches I've encountered along the way (a few years since I've been using it), but not proper implementations. And as you've noticed the one in "data_weighting" I had done it before Alfredo made all the effort to unify the english and spanish versions through the use of "i18n".
And maybe it is time to start working in a substitution, remove/work around, which I'm not sure where to start. I know there are some development kits, but a hint or advice would be nice. One more time thanks and best regards. |
|
Ok, thanks. I have added your path to kruskal_wallis.js, manually, for now. As for how to proceed: I am very glad somebody (you) is actively working on this package, and I hope we'll get it back into proper shape, quickly. Regarding the dependency on "prob": What worries me a bit more, however, is that somehow we ended up with a bunch of separate repositories which have diverged, so that fixes, and improvements (like yours) are not easily mergeable. It would be cool, if you could make a list of what changes are actually meant for inclusion, and sort the other ones into a separate branch. You may also be interested in push access to this repository? |
The QtScript has informed of an error:
Script Error in file:///usr/share/rkward/phpfiles/common.js, line 31: TypeError: Cannot read property 'noquote' of undefined
Backtrace:
quote@file:///usr/share/rkward/phpfiles/common.js:31
makeHeaderCode@file:///usr/share/rkward/phpfiles/common.js:91
https://github.com/file:///usr/share/rkward/phpfiles/common.js:113
printout@file:///home/username/R/x86_64-pc-linux-gnu-library/4.2/rkTeaching/rkward/plugins/non_parametric_tests/kruskal_wallis.js:68
do_printout@file:///usr/share/rkward/phpfiles/common.js:178
%entry@:1
Thanks!!!
Regards.